linux-kernel - [PATCH] tpm_tis_core: Add the error log when the chip startup failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 27 Oct 2020 19:33:57 +0800
From:   Tian Tao <tiantao6@...ilicon.com>
To:     <peterhuewe@....de>, <jarkko@...nel.org>, <jgg@...pe.ca>,
        <linux-integrity@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: [PATCH] tpm_tis_core: Add the error log when the chip startup failed

TPM does not print any log when the startup fails, if there is a
problem with the hardware, wait_wartup is the first place to go wrong,
so add error log when wait_wartup fails to locate the problem.

Signed-off-by: Tian Tao <tiantao6@...ilicon.com>
---
 drivers/char/tpm/tpm_tis_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c
index 92c51c6..660c0a93 100644
--- a/drivers/char/tpm/tpm_tis_core.c
+++ b/drivers/char/tpm/tpm_tis_core.c
@@ -991,6 +991,7 @@ int tpm_tis_core_init(struct device *dev, struct tpm_tis_data *priv, int irq,
 		chip->ops->clk_enable(chip, true);
 
 	if (wait_startup(chip, 0) != 0) {
+		dev_err(dev, "Could not startup the TPM Chip\n");
 		rc = -ENODEV;
 		goto out_err;
 	}
-- 
2.7.4