linux-kernel - Re: [PATCH 1/3] mmc: s3cmci: include GPIO descriptor consumer header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 27 Oct 2020 14:41:43 +0100
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Ben Dooks <ben-linux@...ff.org>,
        Maxime Ripard <mripard@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 1/3] mmc: s3cmci: include GPIO descriptor consumer header

On Mon, 26 Oct 2020 at 16:40, Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> The driver uses GPIO Descriptor Consumer Interface so include proper
> header to fix compile test errors like:
>
>     drivers/mmc/host/s3cmci.c: In function ‘s3cmci_check_sdio_irq’:
>     drivers/mmc/host/s3cmci.c:304:7: error:
>         implicit declaration of function ‘gpiod_get_value’; did you mean ‘gpio_get_value’? [-Werror=implicit-function-declaration]
>
>     drivers/mmc/host/s3cmci.c: In function ‘s3cmci_probe_pdata’:
>     drivers/mmc/host/s3cmci.c:1451:19: error:
>         implicit declaration of function ‘devm_gpiod_get_index’ [-Werror=implicit-function-declaration]
>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/s3cmci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c
> index 643d54eceef6..a33a7823c265 100644
> --- a/drivers/mmc/host/s3cmci.c
> +++ b/drivers/mmc/host/s3cmci.c
> @@ -17,7 +17,7 @@
>  #include <linux/cpufreq.h>
>  #include <linux/debugfs.h>
>  #include <linux/seq_file.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/consumer.h>
>  #include <linux/interrupt.h>
>  #include <linux/irq.h>
>  #include <linux/io.h>
> --
> 2.25.1
>