linux-kernel - Re: [PATCH 2/2] i2c: imx: remove id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e9dd314f-8bb4-f5f5-3dae-9bd4574ff20d@linux-m68k.org>
Date:   Tue, 27 Oct 2020 09:53:59 +1000
From:   Greg Ungerer <gerg@...ux-m68k.org>
To:     Krzysztof Kozlowski <krzk@...nel.org>, peng.fan@....com
Cc:     shawnguo@...nel.org, s.hauer@...gutronix.de, festevam@...il.com,
        kernel@...gutronix.de, linux-imx@....com,
        linux-i2c@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        linux-m68k@...ts.linux-m68k.org,
        Angelo Dureghello <angelo.dureghello@...esys.com>
Subject: Re: [PATCH 2/2] i2c: imx: remove id_table entry


On 24/10/20 1:28 am, Krzysztof Kozlowski wrote:
> On Fri, Oct 23, 2020 at 04:18:23PM +0800, peng.fan@....com wrote:
>> From: Peng Fan <peng.fan@....com>
>>
>> The legacy platform device code has been removed under arch/arm/mach-imx,
>> so we no need id_table entry here.
> 
> Cc: Greg, Geert, Angelo,
> 
> Aren't you breaking Coldfire platforms?

Well spotted Krzysztof. It is used by quite a few of the ColdFire parts.

Regards
Greg


> Best regards,
> Krzysztof
> 
>>
>> Signed-off-by: Peng Fan <peng.fan@....com>
>> ---
>>   drivers/i2c/busses/i2c-imx.c | 14 --------------
>>   1 file changed, 14 deletions(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
>> index ba9d639223ec..7ea36a78abb0 100644
>> --- a/drivers/i2c/busses/i2c-imx.c
>> +++ b/drivers/i2c/busses/i2c-imx.c
>> @@ -233,19 +233,6 @@ static struct imx_i2c_hwdata vf610_i2c_hwdata = {
>>   
>>   };
>>   
>> -static const struct platform_device_id imx_i2c_devtype[] = {
>> -	{
>> -		.name = "imx1-i2c",
>> -		.driver_data = (kernel_ulong_t)&imx1_i2c_hwdata,
>> -	}, {