linux-kernel - Re: [PATCH 1/4] drm/tilcdc: avoid 'make W=2' build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a2Ha+SEmdP9bd-HKN_AwAo9LAfW5LWTkODFOCAUd69QnQ@mail.gmail.com>
Date:   Tue, 27 Oct 2020 17:47:25 +0100
From:   Arnd Bergmann <arnd@...nel.org>
To:     Jyri Sarha <jsarha@...com>
Cc:     David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>,
        Tomi Valkeinen <tomi.valkeinen@...com>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Emil Velikov <emil.velikov@...labora.com>,
        Wambui Karuga <wambui.karugax@...il.com>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] drm/tilcdc: avoid 'make W=2' build failure

On Tue, Oct 27, 2020 at 4:31 PM Jyri Sarha <jsarha@...com> wrote:
> On 26/10/2020 21:41, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@...db.de>
> >
> > The -Wmissing-field-initializer warning when building with W=2
> > turns into an error because tilcdc is built with -Werror:
> >
> > drm/tilcdc/tilcdc_drv.c:431:33: error: missing field 'data' initializer [-Werror,-Wmissing-field-initializers] { "regs", tilcdc_regs_show, 0 },
> > drm/tilcdc/tilcdc_drv.c:432:33: error: missing field 'data' initializer [-Werror,-Wmissing-field-initializers] { "mm",   tilcdc_mm_show,   0 },
> >
> > Add the missing field initializers to address the warning.
> >
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> Reviewed-by: Jyri Sarha <jsarha@...com>

Thanks

> Please let me know if you want me to merge this.

Yes, it would be good if you can merge it directly.

      Arnd