linux-kernel - Re: [PATCH] Fix compat regression in process_vm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wjKhAhOF6Q5JX6a3gdcmZjFFYcBJ-JJ6wybSMHdn2M_Xg@mail.gmail.com>
Date:   Tue, 27 Oct 2020 10:00:03 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Christoph Hellwig <hch@....de>
Cc:     Al Viro <viro@...iv.linux.org.uk>, Jens Axboe <axboe@...nel.dk>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Kyle Huey <me@...ehuey.com>
Subject: Re: [PATCH] Fix compat regression in process_vm_rw()

On Tue, Oct 27, 2020 at 1:01 AM Christoph Hellwig <hch@....de> wrote:
>
> Independent of this fix I think we just need to explicitly prohibit
> cross-access.

Well, prohibiting a 32-bit process from accessing a 64-bit one might
make sense, since it fundamentally cannot work, and returning an
explicit error early might help avoid confusion.

But a 64-bit one can certainly validly look at a 32-bit one (ie
debugging a compat process from a 64-bit gdb or similar is not
unreasonable).

That said, I wonder how muich of a problem that can be, so it may be
sufficient to just fix this compat case up and leave it alone.

So applied,

            Linus