linux-kernel - Re: [PATCH] ARM: kprobes: fix arch_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20201027093057.c685a14b386acacb3c449e3d@kernel.org>
Date:   Tue, 27 Oct 2020 09:30:57 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Russell King <linux@...linux.org.uk>,
        Arnd Bergmann <arnd@...db.de>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: kprobes: fix arch_init_kprobes() prototype

On Mon, 26 Oct 2020 23:12:00 +0100
Arnd Bergmann <arnd@...nel.org> wrote:

> From: Arnd Bergmann <arnd@...db.de>
> 
> With extra warnings enabled, gcc complains about this function
> definition:
> 
> arch/arm/probes/kprobes/core.c: In function 'arch_init_kprobes':
> arch/arm/probes/kprobes/core.c:465:12: warning: old-style function definition [-Wold-style-definition]
>   465 | int __init arch_init_kprobes()
> 
> Fixes: 24ba613c9d6c ("ARM kprobes: core code")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Looks good to me.

Acked-by: Masami Hiramatsu <mhiramat@...nel.org>

Thanks Arnd!

> ---
>  arch/arm/probes/kprobes/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/probes/kprobes/core.c b/arch/arm/probes/kprobes/core.c
> index a9653117ca0d..e513d8a46776 100644
> --- a/arch/arm/probes/kprobes/core.c
> +++ b/arch/arm/probes/kprobes/core.c
> @@ -462,7 +462,7 @@ static struct undef_hook kprobes_arm_break_hook = {
>  
>  #endif /* !CONFIG_THUMB2_KERNEL */
>  
> -int __init arch_init_kprobes()
> +int __init arch_init_kprobes(void)
>  {
>  	arm_probes_decode_init();
>  #ifdef CONFIG_THUMB2_KERNEL
> -- 
> 2.27.0
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>