linux-kernel - Re: [PATCH v5 seccomp 0/5]seccomp: Add bitmap cache of constant allow filter results

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <160382601078.2318738.11754677445961373147.b4-ty@chromium.org>
Date:   Tue, 27 Oct 2020 12:14:50 -0700
From:   Kees Cook <keescook@...omium.org>
To:     YiFei Zhu <zhuyifei1999@...il.com>,
        containers@...ts.linux-foundation.org
Cc:     Kees Cook <keescook@...omium.org>, Tianyin Xu <tyxu@...inois.edu>,
        Tobin Feldman-Fitzthum <tobin@....com>,
        Jack Chen <jianyan2@...inois.edu>,
        YiFei Zhu <yifeifz2@...inois.edu>,
        Valentin Rothberg <vrothber@...hat.com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Dimitrios Skarlatos <dskarlat@...cmu.edu>,
        Andy Lutomirski <luto@...capital.net>,
        David Laight <David.Laight@...lab.com>, bpf@...r.kernel.org,
        Jann Horn <jannh@...gle.com>,
        Giuseppe Scrivano <gscrivan@...hat.com>,
        Josep Torrellas <torrella@...inois.edu>,
        Hubertus Franke <frankeh@...ibm.com>,
        Will Drewry <wad@...omium.org>, linux-kernel@...r.kernel.org,
        Tycho Andersen <tycho@...ho.pizza>,
        Aleksa Sarai <cyphar@...har.com>
Subject: Re: [PATCH v5 seccomp 0/5]seccomp: Add bitmap cache of constant allow filter results

On Sun, 11 Oct 2020 10:47:41 -0500, YiFei Zhu wrote:
> Alternative: https://lore.kernel.org/lkml/20200923232923.3142503-1-keescook@chromium.org/T/
> 
> Major differences from the linked alternative by Kees:
> * No x32 special-case handling -- not worth the complexity
> * No caching of denylist -- not worth the complexity
> * No seccomp arch pinning -- I think this is an independent feature
> * The bitmaps are part of the filters rather than the task.
> 
> [...]

Applied to for-next/seccomp, thanks! I left off patch 5 for now until
we sort out the rest of the SECCOMP_FILTER architectures, and tweaked
patch 3 to include the architecture names.

[1/4] seccomp/cache: Lookup syscall allowlist bitmap for fast path
      https://git.kernel.org/kees/c/f94defb8bf46
[2/4] seccomp/cache: Add "emulator" to check if filter is constant allow
      https://git.kernel.org/kees/c/e7dc9f1e5f6b
[3/4] x86: Enable seccomp architecture tracking
      https://git.kernel.org/kees/c/1f68a4d393fe
[4/4] selftests/seccomp: Compare bitmap vs filter overhead
      https://git.kernel.org/kees/c/57a339117e52

-- 
Kees Cook