linux-kernel - Re: [PATCH 1/3] x86/debug: Fix BTF handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201027194126.GR2628@hirez.programming.kicks-ass.net>
Date:   Tue, 27 Oct 2020 20:41:26 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     tglx@...utronix.de, luto@...nel.org, me@...ehuey.com
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org,
        torvalds@...ux-foundation.org, rocallahan@...il.com,
        alexandre.chartre@...cle.com, paulmck@...nel.org,
        frederic@...nel.org, pbonzini@...hat.com,
        sean.j.christopherson@...el.com, mhiramat@...nel.org,
        pmladek@...e.com, joel@...lfernandes.org, rostedt@...dmis.org,
        boris.ostrovsky@...cle.com, jgross@...e.com, brgerst@...il.com,
        jpoimboe@...hat.com, daniel.thompson@...aro.org,
        julliard@...ehq.org, pgofman@...eweavers.com
Subject: Re: [PATCH 1/3] x86/debug: Fix BTF handling

On Tue, Oct 27, 2020 at 10:15:05AM +0100, Peter Zijlstra wrote:

> @@ -873,6 +866,20 @@ static __always_inline void exc_debug_ke
>  	 */
>  	WARN_ON_ONCE(user_mode(regs));
>  
> +	if (test_thread_flag(TIF_BLOCKSTEP)) {
> +		/*
> +		 * The SDM says "The processor clears the BTF flag when it
> +		 * generates a debug exception." but PTRACE_BLOCKSTEP requested
> +		 * it for userspace, but we just took a kernel #DB, so re-set
> +		 * BTF.
> +		 */
> +		unsigned long debugctl;
> +
> +		rdmsrl(MSR_IA32_DEBUGCTLMSR, debugctl);
> +		debugctl |= DEBUGCTLMSR_BTF;
> +		wrmsrl(MSR_IA32_DEBUGCTLMSR, debugctl);
> +	}
> +
>  	/*
>  	 * Catch SYSENTER with TF set and clear DR_STEP. If this hit a
>  	 * watchpoint at the same time then that will still be handled.

Masami, how does BTF interact with !optimized kprobes that single-step?

The best answer I can come up with is 'poorly' :/