linux-kernel - Re: [PATCH v10 2/5] ACPI/PCI: Ignore _OSC negotiation result if pcie_ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202010270829.5beI8KER-lkp@intel.com>
Date:   Tue, 27 Oct 2020 09:01:11 +0800
From:   kernel test robot <lkp@...el.com>
To:     Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>, bhelgaas@...gle.com
Cc:     kbuild-all@...ts.01.org, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, ashok.raj@...el.com,
        sathyanarayanan.kuppuswamy@...ux.intel.com, knsathya@...nel.org
Subject: Re: [PATCH v10 2/5] ACPI/PCI: Ignore _OSC negotiation result if
 pcie_ports_native is set.

Hi Kuppuswamy,

I love your patch! Perhaps something to improve:

[auto build test WARNING on pci/next]
[also build test WARNING on pm/linux-next linus/master linux/master v5.10-rc1 next-20201026]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Kuppuswamy-Sathyanarayanan/Simplify-PCIe-native-ownership-detection-logic/20201027-030011
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: i386-randconfig-m021-20201026 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

smatch warnings:
drivers/acpi/pci_root.c:923 acpi_pci_root_create() warn: inconsistent indenting

vim +923 drivers/acpi/pci_root.c

   884	
   885	struct pci_bus *acpi_pci_root_create(struct acpi_pci_root *root,
   886					     struct acpi_pci_root_ops *ops,
   887					     struct acpi_pci_root_info *info,
   888					     void *sysdata)
   889	{
   890		int ret, busnum = root->secondary.start;
   891		struct acpi_device *device = root->device;
   892		int node = acpi_get_node(device->handle);
   893		struct pci_bus *bus;
   894		struct pci_host_bridge *host_bridge;
   895		union acpi_object *obj;
   896		u32 ctrl;
   897	
   898		info->root = root;
   899		info->bridge = device;
   900		info->ops = ops;
   901		INIT_LIST_HEAD(&info->resources);
   902		snprintf(info->name, sizeof(info->name), "PCI Bus %04x:%02x",
   903			 root->segment, busnum);
   904	
   905		if (ops->init_info && ops->init_info(info))
   906			goto out_release_info;
   907		if (ops->prepare_resources)
   908			ret = ops->prepare_resources(info);
   909		else
   910			ret = acpi_pci_probe_root_resources(info);
   911		if (ret < 0)
   912			goto out_release_info;
   913	
   914		pci_acpi_root_add_resources(info);
   915		pci_add_resource(&info->resources, &root->secondary);
   916		bus = pci_create_root_bus(NULL, busnum, ops->pci_ops,
   917					  sysdata, &info->resources);
   918		if (!bus)
   919			goto out_release_info;
   920	
   921		host_bridge = to_pci_host_bridge(bus->bridge);
   922	
 > 923		  if (pcie_ports_native) {
   924			  decode_osc_control(root, "OS forcibly taking over",
   925					     OSC_PCI_EXPRESS_CONTROL_MASKS);
   926		  } else {
   927			  ctrl = root->osc_control_set;
   928			  OSC_OWNER(ctrl, OSC_PCI_EXPRESS_NATIVE_HP_CONTROL,
   929				    host_bridge->native_pcie_hotplug);
   930			  OSC_OWNER(ctrl, OSC_PCI_EXPRESS_AER_CONTROL,
   931				    host_bridge->native_aer);
   932			  OSC_OWNER(ctrl, OSC_PCI_EXPRESS_PME_CONTROL,
   933				    host_bridge->native_pme);
   934			  OSC_OWNER(ctrl, OSC_PCI_EXPRESS_LTR_CONTROL,
   935				    host_bridge->native_ltr);
   936			  OSC_OWNER(ctrl, OSC_PCI_EXPRESS_DPC_CONTROL,
   937				    host_bridge->native_dpc);
   938		  }
   939	
   940		if (!(root->osc_control_set & OSC_PCI_SHPC_NATIVE_HP_CONTROL))
   941			host_bridge->native_shpc_hotplug = 0;
   942	
   943		/*
   944		 * Evaluate the "PCI Boot Configuration" _DSM Function.  If it
   945		 * exists and returns 0, we must preserve any PCI resource
   946		 * assignments made by firmware for this host bridge.
   947		 */
   948		obj = acpi_evaluate_dsm(ACPI_HANDLE(bus->bridge), &pci_acpi_dsm_guid, 1,
   949					DSM_PCI_PRESERVE_BOOT_CONFIG, NULL);
   950		if (obj && obj->type == ACPI_TYPE_INTEGER && obj->integer.value == 0)
   951			host_bridge->preserve_config = 1;
   952		ACPI_FREE(obj);
   953	
   954		pci_scan_child_bus(bus);
   955		pci_set_host_bridge_release(host_bridge, acpi_pci_root_release_info,
   956					    info);
   957		if (node != NUMA_NO_NODE)
   958			dev_printk(KERN_DEBUG, &bus->dev, "on NUMA node %d\n", node);
   959		return bus;
   960	
   961	out_release_info:
   962		__acpi_pci_root_release_info(info);
   963		return NULL;
   964	}
   965	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (39290 bytes)