linux-kernel - Re: [PATCH v3] zram: break the strict dependency from lzo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201027012204.GD2412725@google.com>
Date:   Tue, 27 Oct 2020 10:22:04 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:     Rui Salvaterra <rsalvaterra@...il.com>
Cc:     minchan@...nel.org, ngupta@...are.org,
        sergey.senozhatsky.work@...il.com, linux-kernel@...r.kernel.org,
        linux-block@...r.kernel.org
Subject: Re: [PATCH v3] zram: break the strict dependency from lzo

On (20/10/26 08:51), Rui Salvaterra wrote:
>  static const char * const backends[] = {
> +#if IS_ENABLED(CONFIG_CRYPTO_LZO)
>  	"lzo",
>  	"lzo-rle",
> +#endif
>  #if IS_ENABLED(CONFIG_CRYPTO_LZ4)
>  	"lz4",
>  #endif
[..]
> +static const char *default_compressor =
> +#if IS_ENABLED(CONFIG_CRYPTO_LZO)
> +	"lzo-rle";
> +#elif IS_ENABLED(CONFIG_CRYPTO_LZ4)
> +	"lz4";
> +#elif IS_ENABLED(CONFIG_CRYPTO_LZ4HC)
> +	"lz4hc";
> +#elif IS_ENABLED(CONFIG_CRYPTO_842)
> +	"842";
> +#elif IS_ENABLED(CONFIG_CRYPTO_ZSTD)
> +	"zstd";
> +#endif

Honestly, I'm not entirely excited. lzo is a fallback compression
algorithm. If you want to use zram with something else thenconfigure
zram to use something else. What do all these #if/#elif buy us?

	-ss