linux-kernel - Re: [PATCH v1 1/1] scsi: ufs: Keep UFS regulators on when autobkops enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1603764857.2104.6.camel@mtkswgap22>
Date:   Tue, 27 Oct 2020 10:14:17 +0800
From:   Stanley Chu <stanley.chu@...iatek.com>
To:     Asutosh Das <asutoshd@...eaurora.org>
CC:     <cang@...eaurora.org>, <martin.petersen@...cle.com>,
        <linux-scsi@...r.kernel.org>,
        "Bao D. Nguyen" <nguyenb@...eaurora.org>,
        <linux-arm-msm@...r.kernel.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        "Avri Altman" <avri.altman@....com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Bean Huo <beanhuo@...ron.com>,
        Bart Van Assche <bvanassche@....org>,
        "open list" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 1/1] scsi: ufs: Keep UFS regulators on when autobkops
 enabled

Hi,

On Mon, 2020-10-26 at 14:31 -0700, Asutosh Das wrote:
> From: "Bao D. Nguyen" <nguyenb@...eaurora.org>
> 
> When bkops is enabled, the UFS device may do bkops during suspend.
> With bkops enabled during suspend, keep the regulators
> in active operation configuration, allowing the device to draw
> high power to support bkops and avoid over current event.
> 
> Signed-off-by: Bao D. Nguyen <nguyenb@...eaurora.org>
> Signed-off-by: Asutosh Das <asutoshd@...eaurora.org>
> ---
>  drivers/scsi/ufs/ufshcd.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 47c544d..a94543c 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -8523,7 +8523,9 @@ static int ufshcd_suspend(struct ufs_hba *hba, enum ufs_pm_op pm_op)
>  	if (ret)
>  		goto set_dev_active;
>  
> -	ufshcd_vreg_set_lpm(hba);
> +	/* Device may perform bkops if autobkops is enabled */
> +	if (!hba->auto_bkops_enabled)
> +		ufshcd_vreg_set_lpm(hba);

If auto bkops is allowed and enabled during runtime suspend (currently
auto bkops is allow in runtime suspend only, and not allowed in system
suspend), hba->dev_info.b_rpm_dev_flush_capable would be true and keep
the current device power mode, say Active Power Mode. In this case,
regulator would not be set as lpm mode by ufshcd_vreg_set_lpm().

Please correct me if I was wrong.

Thanks,
Stanley Chu