linux-kernel - Re: [PATCH RESEND 3/3] net: core: fix some kernel-doc markups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201026200646.50dbb231@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Mon, 26 Oct 2020 20:06:46 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc:     Linux Doc Mailing List <linux-doc@...r.kernel.org>,
        Mark Brown <broonie@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        "Jonathan Corbet" <corbet@....net>, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH RESEND 3/3] net: core: fix some kernel-doc markups

On Mon, 26 Oct 2020 10:47:38 +0100 Mauro Carvalho Chehab wrote:
> Some identifiers have different names between their prototypes
> and the kernel-doc markup.
> 
> In the specific case of netif_subqueue_stopped(), keep the
> current markup for __netif_subqueue_stopped(), adding a
> new one for netif_subqueue_stopped().
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>

> @@ -3590,6 +3590,13 @@ static inline bool __netif_subqueue_stopped(const struct net_device *dev,
>  	return netif_tx_queue_stopped(txq);
>  }
>  
> +/**
> + *	netif_subqueue_stopped - test status of subqueue
> + *	@dev: network device
> + *	@skb: sub queue buffer pointer

Ah, no: "socket buffer from which to get the mapping"

> + *
> + * Check individual transmit queue of a device with multiple transmit queues.
> + */
>  static inline bool netif_subqueue_stopped(const struct net_device *dev,
>  					  struct sk_buff *skb)
>  {