linux-kernel - Re: [PATCH 11/14] USB: serial: keyspan_pda: clean up xircom/entrega support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201027080912.GA4085@localhost>
Date:   Tue, 27 Oct 2020 09:09:12 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:     Johan Hovold <johan@...nel.org>, linux-usb@...r.kernel.org,
        "Ahmed S . Darwish" <a.darwish@...utronix.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/14] USB: serial: keyspan_pda: clean up xircom/entrega
 support

On Mon, Oct 26, 2020 at 01:00:02PM +0100, Sebastian Andrzej Siewior wrote:
> On 2020-10-25 18:45:57 [+0100], Johan Hovold wrote:
> > Drop the separate Kconfig symbol for Xircom / Entrega and always include
> > support in the keyspan_pda driver.
> > 
> > Signed-off-by: Johan Hovold <johan@...nel.org>
> > ---
> >  drivers/usb/serial/Kconfig       | 19 ++-------
> >  drivers/usb/serial/Makefile      |  1 -
> >  drivers/usb/serial/keyspan_pda.c | 68 +++++---------------------------
> >  3 files changed, 13 insertions(+), 75 deletions(-)
> > 
> > diff --git a/drivers/usb/serial/Kconfig b/drivers/usb/serial/Kconfig
> > index 4007fa25a8ff..a21ff5ab6df9 100644
> > --- a/drivers/usb/serial/Kconfig
> > +++ b/drivers/usb/serial/Kconfig
> > @@ -538,17 +538,6 @@ config USB_SERIAL_CYBERJACK
> >  
> >  	  If unsure, say N.
> >  
> > -config USB_SERIAL_XIRCOM
> 
> Should this patch remove this symbol from defconfigs or does it happen
> every now and then on its own? All of them select USB_SERIAL_KEYSPAN_PDA
> so there is no loss.

Good catch, thanks! I'll remove those config entries as part of this
patch.

Johan