linux-kernel - Re: [PATCH 2/2] irqchip: bcm2836: fix section mismatch warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49f17502445e5ae5b35df15577957ae6@kernel.org>
Date:   Tue, 27 Oct 2020 09:03:51 +0000
From:   Marc Zyngier <maz@...nel.org>
To:     balbi@...nel.org
Cc:     Mathieu Poirier <mathieu.poirier@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com, coresight@...ts.linaro.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] irqchip: bcm2836: fix section mismatch warning

On 2020-10-27 08:51, balbi@...nel.org wrote:
> From: Felipe Balbi <balbi@...nel.org>
> 
> Fix the following warning:
> 
> WARNING: modpost: vmlinux.o(.text.unlikely+0x17b2c): Section mismatch
> in reference from the function bcm2836_arm_irqchip_smp_init() to the
> function .init.text:set_smp_ipi_range()
> The function bcm2836_arm_irqchip_smp_init() references
> the function __init set_smp_ipi_range().
> This is often because bcm2836_arm_irqchip_smp_init lacks a __init
> annotation or the annotation of set_smp_ipi_range is wrong.
> 
> Signed-off-by: Felipe Balbi <balbi@...nel.org>
> ---
>  drivers/irqchip/irq-bcm2836.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-bcm2836.c 
> b/drivers/irqchip/irq-bcm2836.c
> index 97838eb705f9..cbc7c740e4dc 100644
> --- a/drivers/irqchip/irq-bcm2836.c
> +++ b/drivers/irqchip/irq-bcm2836.c
> @@ -244,7 +244,7 @@ static int bcm2836_cpu_dying(unsigned int cpu)
> 
>  #define BITS_PER_MBOX	32
> 
> -static void bcm2836_arm_irqchip_smp_init(void)
> +static void __init bcm2836_arm_irqchip_smp_init(void)
>  {
>  	struct irq_fwspec ipi_fwspec = {
>  		.fwnode		= intc.domain->fwnode,

I already have a fix for this one[1], which should be in -next.

Thanks,

         M.

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?h=irq/irqchip-next&id=57733e009f0c7e0526e10a18be12f56996c5460e
-- 
Jazz is not dead. It just smells funny...