[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20201027091604.GB10762@kozik-lap>
Date: Tue, 27 Oct 2020 10:16:04 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Dmitry Osipenko <digetx@...il.com>
Cc: Thierry Reding <thierry.reding@...il.com>,
Jonathan Hunter <jonathanh@...dia.com>,
Georgi Djakov <georgi.djakov@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>,
Peter De Schrijver <pdeschrijver@...dia.com>,
MyungJoo Ham <myungjoo.ham@...sung.com>,
Kyungmin Park <kyungmin.park@...sung.com>,
Chanwoo Choi <cw00.choi@...sung.com>,
Mikko Perttunen <cyndis@...si.fi>,
Viresh Kumar <vireshk@...nel.org>,
Peter Geis <pgwipeout@...il.com>,
Nicolas Chauvet <kwizart@...il.com>,
linux-tegra@...r.kernel.org, linux-pm@...r.kernel.org,
linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
devicetree@...r.kernel.org
Subject: Re: [PATCH v6 23/52] ARM: tegra: Add interconnect properties to
Tegra124 device-tree
On Mon, Oct 26, 2020 at 01:17:06AM +0300, Dmitry Osipenko wrote:
> Add interconnect properties to the Memory Controller, External Memory
> Controller and the Display Controller nodes in order to describe hardware
> interconnection.
>
> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
> ---
> arch/arm/boot/dts/tegra124.dtsi | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi
> index 64f488ba1e72..1801e30b1d3a 100644
> --- a/arch/arm/boot/dts/tegra124.dtsi
> +++ b/arch/arm/boot/dts/tegra124.dtsi
> @@ -113,6 +113,19 @@ dc@...00000 {
> iommus = <&mc TEGRA_SWGROUP_DC>;
>
> nvidia,head = <0>;
> +
> + interconnects = <&mc TEGRA124_MC_DISPLAY0A &emc>,
This does not compile.
> + <&mc TEGRA124_MC_DISPLAY0B &emc>,
> + <&mc TEGRA124_MC_DISPLAY0C &emc>,
> + <&mc TEGRA124_MC_DISPLAYHC &emc>,
> + <&mc TEGRA124_MC_DISPLAYD &emc>,
> + <&mc TEGRA124_MC_DISPLAYT &emc>;
> + interconnect-names = "wina",
> + "winb",
> + "winc",
> + "cursor",
> + "wind",
> + "wint";
> };
>
> dc@...40000 {
> @@ -127,6 +140,15 @@ dc@...40000 {
> iommus = <&mc TEGRA_SWGROUP_DCB>;
>
> nvidia,head = <1>;
> +
> + interconnects = <&mc TEGRA124_MC_DISPLAY0AB &emc>,
> + <&mc TEGRA124_MC_DISPLAY0BB &emc>,
> + <&mc TEGRA124_MC_DISPLAY0CB &emc>,
> + <&mc TEGRA124_MC_DISPLAYHCB &emc>;
> + interconnect-names = "wina",
> + "winb",
> + "winc",
> + "cursor";
> };
>
> hdmi: hdmi@...80000 {
> @@ -628,6 +650,7 @@ mc: memory-controller@...19000 {
>
> #iommu-cells = <1>;
> #reset-cells = <1>;
> + #interconnect-cells = <1>;
> };
>
> emc: external-memory-controller@...1b000 {
> @@ -637,6 +660,8 @@ emc: external-memory-controller@...1b000 {
> clock-names = "emc";
>
> nvidia,memory-controller = <&mc>;
> +
No need for blank line.
Best regards,
Krzysztof
Powered by blists - more mailing lists