linux-kernel - Re: [PATCH] soc: ti: ti_sci_pm_domains: check for proper args count in xlate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201028214336.qfwbs46j5x6cpjhr@award>
Date:   Wed, 28 Oct 2020 16:43:36 -0500
From:   Nishanth Menon <nm@...com>
To:     Tero Kristo <t-kristo@...com>
CC:     <ssantosh@...nel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] soc: ti: ti_sci_pm_domains: check for proper args count
 in xlate

On 16:17-20201028, Tero Kristo wrote:
> K2G devices still only use single parameter for power-domains property,
> so check for this properly in the driver. Without this, every peripheral
> fails to probe resulting in boot failure.
> 
> Fixes: efa5c01cd7ee ("soc: ti: ti_sci_pm_domains: switch to use multiple genpds instead of one")
> Reported-by: Nishanth Menon <nm@...com>
> Signed-off-by: Tero Kristo <t-kristo@...com>
> ---
>  drivers/soc/ti/ti_sci_pm_domains.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/ti/ti_sci_pm_domains.c b/drivers/soc/ti/ti_sci_pm_domains.c
> index af2126d2b2ff..8afb3f45d263 100644
> --- a/drivers/soc/ti/ti_sci_pm_domains.c
> +++ b/drivers/soc/ti/ti_sci_pm_domains.c
> @@ -91,7 +91,7 @@ static struct generic_pm_domain *ti_sci_pd_xlate(
>  	struct genpd_onecell_data *genpd_data = data;
>  	unsigned int idx = genpdspec->args[0];
>  
> -	if (genpdspec->args_count < 2)
> +	if (genpdspec->args_count != 1 && genpdspec->args_count != 2)
>  		return ERR_PTR(-EINVAL);
>  
>  	if (idx >= genpd_data->num_domains) {


Thanks Tero.

Acked-by: Nishanth Menon <nm@...com>

Santosh: can we queue this one for 5.10? - I am trying to track and get
all platforms booting and functional in 5.10

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D