linux-kernel - Re: [PATCH v3 8/9] perf mem: Return NULL for event 'ldst' on PowerPC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1603877629.hjro28ddup.naveen@linux.ibm.com>
Date:   Wed, 28 Oct 2020 15:05:03 +0530
From:   "Naveen N. Rao" <naveen.n.rao@...ux.vnet.ibm.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Al Grant <Al.Grant@....com>,
        André Przywara <andre.przywara@....com>,
        Ian Rogers <irogers@...gle.com>,
        James Clark <james.clark@....com>,
        John Garry <john.garry@...wei.com>,
        Jiri Olsa <jolsa@...hat.com>, Leo Yan <leo.yan@...aro.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Wei Li <liwei391@...wei.com>,
        Mark Rutland <mark.rutland@....com>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Ingo Molnar <mingo@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Kemeng Shi <shikemeng@...wei.com>,
        Will Deacon <will@...nel.org>,
        Madhavan Srinivasan <maddy@...ux.ibm.com>
Subject: Re: [PATCH v3 8/9] perf mem: Return NULL for event 'ldst' on PowerPC

[+ Maddy]

Leo Yan wrote:
> If user specifies event type "ldst", PowerPC's perf_mem_events__name()
> will wrongly return the store event name "cpu/mem-stores/".
> 
> This patch changes to return NULL for the event "ldst" on PowerPC.
> 
> Signed-off-by: Leo Yan <leo.yan@...aro.org>
> ---
>  tools/perf/arch/powerpc/util/mem-events.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/arch/powerpc/util/mem-events.c b/tools/perf/arch/powerpc/util/mem-events.c
> index 07fb5e049488..90c5a0760685 100644
> --- a/tools/perf/arch/powerpc/util/mem-events.c
> +++ b/tools/perf/arch/powerpc/util/mem-events.c
> @@ -7,6 +7,8 @@ char *perf_mem_events__name(int i)
>  {
>  	if (i == PERF_MEM_EVENTS__LOAD)
>  		return (char *) "cpu/mem-loads/";
> -
> -	return (char *) "cpu/mem-stores/";
> +	else if (i == PERF_MEM_EVENTS__STORE)
> +		return (char *) "cpu/mem-stores/";
> +	else
> +		return NULL;
>  }
> -- 
> 2.17.1
> 
>