linux-kernel - 回复: [PATCH v2] kthread_worker: re-set CPU affinities if CPU come online

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR11MB263255ED056CED38285FC95BFF170@BYAPR11MB2632.namprd11.prod.outlook.com>
Date:   Wed, 28 Oct 2020 08:45:36 +0000
From:   "Zhang, Qiang" <Qiang.Zhang@...driver.com>
To:     Thomas Gleixner <tglx@...utronix.de>,
        "pmladek@...e.com" <pmladek@...e.com>,
        "tj@...nel.org" <tj@...nel.org>
CC:     "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: 回复: [PATCH v2] kthread_worker: re-set CPU affinities if CPU come online



________________________________________
发件人: Thomas Gleixner <tglx@...utronix.de>
发送时间: 2020年10月28日 16:30
收件人: Zhang, Qiang; pmladek@...e.com; tj@...nel.org
抄送: akpm@...ux-foundation.org; linux-mm@...ck.org; linux-kernel@...r.kernel.org
主题: Re: [PATCH v2] kthread_worker: re-set CPU affinities if CPU come online

[Please note this e-mail is from an EXTERNAL e-mail address]

On Wed, Oct 28 2020 at 15:30, qiang zhang wrote:
> From: Zqiang <qiang.zhang@...driver.com>
>
> When someone CPU offlined, the 'kthread_worker' which bind this CPU,
> will run anywhere, if this CPU online, recovery of 'kthread_worker'
> affinity by cpuhp notifiers.
>
> Signed-off-by: Zqiang <qiang.zhang@...driver.com>
> ---
>  v1->v2:
>  rename variable kworker_online to kthread_worker_online.
>  add 'cpuhp_node' and 'bind_cpu' init in KTHREAD_WORKER_INIT.
>  add a comment explaining for WARN_ON_ONCE.

>How is that addressing any of the comments I made on V1 of this?

Do you mean the following problem:
 
"The dynamic hotplug states run late. What's preventing work to be queued
on such a worker before it is bound to the CPU again?"

Thanks
Qiang
>
>Thanks,
>
>       tglx