linux-kernel - Re: [PATCH 4.19 228/264] PM: hibernate: remove the bogus call to get_gendisk() in software

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201028071236.GA16112@lst.de>
Date:   Wed, 28 Oct 2020 08:12:37 +0100
From:   Christoph Hellwig <hch@....de>
To:     Pavel Machek <pavel@...x.de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Christoph Hellwig <hch@....de>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 4.19 228/264] PM: hibernate: remove the bogus call to
 get_gendisk() in software_resume()

On Wed, Oct 28, 2020 at 08:10:57AM +0100, Pavel Machek wrote:
> This does not fix anything in 4.19, and should not be there.
> 
> It will break resume for people using resumewait option and using
> numeric values, as original changelog explains. Eventually, someone
> will cry regression and we'll have to fix it in the mainline, but no
> need to bring this to -stable, too.

If this code ever gets hit this patch fixes a reference count leak.