linux-kernel - Re: [PATCH] x86/mm/ident_map: Check for errors from ident_pud

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201028132954.GK22179@suse.de>
Date:   Wed, 28 Oct 2020 14:29:54 +0100
From:   Joerg Roedel <jroedel@...e.de>
To:     Arvind Sankar <nivedita@...m.mit.edu>
Cc:     Dave Hansen <dave.hansen@...ux.intel.com>,
        Andy Lutomirski <luto@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>, x86@...nel.org,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/mm/ident_map: Check for errors from ident_pud_init()

On Tue, Oct 27, 2020 at 07:06:48PM -0400, Arvind Sankar wrote:
> Commit
>   ea3b5e60ce80 ("x86/mm/ident_map: Add 5-level paging support")
> added ident_p4d_init() to support 5-level paging, but this function
> doesn't check and return errors from ident_pud_init().
> 
> For example, the decompressor stub uses this code to create an identity
> mapping. If it runs out of pages while trying to allocate a PMD
> pagetable, the error will be currently ignored.
> 
> Fix this to propagate errors.
> 
> Signed-off-by: Arvind Sankar <nivedita@...m.mit.edu>
> Fixes: ea3b5e60ce80 ("x86/mm/ident_map: Add 5-level paging support")
> ---
>  arch/x86/mm/ident_map.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)

Reviewed-by: Joerg Roedel <jroedel@...e.de>