linux-kernel - Re: [PATCH 2/2] tools, bpftool: Remove two unused variables.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzbeJqCq_OHrBQWHoXtALPSHZ7hY2OHL59BuvCcfF1nrpQ@mail.gmail.com>
Date:   Tue, 27 Oct 2020 20:41:19 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Ian Rogers <irogers@...gle.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        Andrii Nakryiko <andrii@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...omium.org>,
        Nathan Chancellor <natechancellor@...il.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Quentin Monnet <quentin@...valent.com>,
        Michal Rostecki <mrostecki@...nsuse.org>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        Tobias Klauser <tklauser@...tanz.ch>,
        open list <linux-kernel@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH 2/2] tools, bpftool: Remove two unused variables.

On Tue, Oct 27, 2020 at 4:37 PM Ian Rogers <irogers@...gle.com> wrote:
>
> Avoid an unused variable warning.
>
> Signed-off-by: Ian Rogers <irogers@...gle.com>
> ---

Acked-by: Andrii Nakryiko <andrii@...nel.org>

>  tools/bpf/bpftool/skeleton/profiler.bpf.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/bpf/bpftool/skeleton/profiler.bpf.c b/tools/bpf/bpftool/skeleton/profiler.bpf.c
> index 4e3512f700c0..ce5b65e07ab1 100644
> --- a/tools/bpf/bpftool/skeleton/profiler.bpf.c
> +++ b/tools/bpf/bpftool/skeleton/profiler.bpf.c
> @@ -70,7 +70,7 @@ int BPF_PROG(fentry_XXX)
>  static inline void
>  fexit_update_maps(u32 id, struct bpf_perf_event_value *after)
>  {
> -       struct bpf_perf_event_value *before, diff, *accum;
> +       struct bpf_perf_event_value *before, diff;
>
>         before = bpf_map_lookup_elem(&fentry_readings, &id);
>         /* only account samples with a valid fentry_reading */
> @@ -95,7 +95,7 @@ int BPF_PROG(fexit_XXX)
>  {
>         struct bpf_perf_event_value readings[MAX_NUM_MATRICS];
>         u32 cpu = bpf_get_smp_processor_id();
> -       u32 i, one = 1, zero = 0;
> +       u32 i, zero = 0;
>         int err;
>         u64 *count;
>
> --
> 2.29.0.rc2.309.g374f81d7ae-goog
>