linux-kernel - fs/nfsd/nfs4xdr.c:4657 nfsd4_encode_read_plus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202010290717.qfxgXtma-lkp@intel.com>
Date:   Thu, 29 Oct 2020 07:24:21 +0800
From:   kernel test robot <lkp@...el.com>
To:     Anna Schumaker <Anna.Schumaker@...app.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        "J. Bruce Fields" <bfields@...hat.com>
Subject: fs/nfsd/nfs4xdr.c:4657 nfsd4_encode_read_plus_hole() warn:
 inconsistent indenting

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   23859ae44402f4d935b9ee548135dd1e65e2cbf4
commit: 2db27992dd565bf400658edc18f67aed0b6bc6cb NFSD: Add READ_PLUS hole segment encoding
date:   2 weeks ago
config: parisc-randconfig-m031-20201028 (attached as .config)
compiler: hppa64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

New smatch warnings:
fs/nfsd/nfs4xdr.c:4657 nfsd4_encode_read_plus_hole() warn: inconsistent indenting

Old smatch warnings:
fs/nfsd/nfs4xdr.c:679 nfsd4_decode_close() warn: ignoring unreachable code.

vim +4657 fs/nfsd/nfs4xdr.c

  4642	
  4643	static __be32
  4644	nfsd4_encode_read_plus_hole(struct nfsd4_compoundres *resp,
  4645				    struct nfsd4_read *read,
  4646				    unsigned long maxcount, u32 *eof)
  4647	{
  4648		struct file *file = read->rd_nf->nf_file;
  4649		__be32 *p;
  4650	
  4651		/* Content type, offset, byte count */
  4652		p = xdr_reserve_space(&resp->xdr, 4 + 8 + 8);
  4653		if (!p)
  4654			return nfserr_resource;
  4655	
  4656		*p++ = htonl(NFS4_CONTENT_HOLE);
> 4657		 p   = xdr_encode_hyper(p, read->rd_offset);
  4658		 p   = xdr_encode_hyper(p, maxcount);
  4659	
  4660		*eof = (read->rd_offset + maxcount) >= i_size_read(file_inode(file));
  4661		return nfs_ok;
  4662	}
  4663	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (36051 bytes)