linux-kernel - Re: [PATCH 11/11] afs: Fix dirty-region encoding on ppc32 with 64K pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <957373.1603972118@warthog.procyon.org.uk>
Date:   Thu, 29 Oct 2020 11:48:38 +0000
From:   David Howells <dhowells@...hat.com>
To:     linux-afs@...ts.infradead.org
Cc:     dhowells@...hat.com, kernel test robot <lkp@...el.com>,
        "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/11] afs: Fix dirty-region encoding on ppc32 with 64K pages

David Howells <dhowells@...hat.com> wrote:

> +static inline unsigned int afs_page_dirty_resolution(void)
> +{
> +	long shift = PAGE_SHIFT - (__AFS_PAGE_PRIV_SHIFT - 1);

This should be int, not long, in case we get an explicitly unsigned int number
included in the mix (say from thp_order() with THP support).

David