linux-kernel - [PATCH -next] dma-buf: heaps: Make sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1603973443-64798-1-git-send-email-zou_wei@huawei.com>
Date:   Thu, 29 Oct 2020 20:10:43 +0800
From:   Zou Wei <zou_wei@...wei.com>
To:     <sumit.semwal@...aro.org>, <benjamin.gaignard@...aro.org>,
        <lmark@...eaurora.org>, <labbott@...hat.com>,
        <Brian.Starkey@....com>, <john.stultz@...aro.org>,
        <christian.koenig@....com>
CC:     <linux-media@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <linaro-mm-sig@...ts.linaro.org>, <linux-kernel@...r.kernel.org>,
        Zou Wei <zou_wei@...wei.com>
Subject: [PATCH -next] dma-buf: heaps: Make sys_heap static

Fix the following sparse warning:

drivers/dma-buf/heaps/system_heap.c:23:17: warning: symbol 'sys_heap' was not declared. Should it be static?

sys_heap has only call within system_heap.c
It should be static

Reported-by: Hulk Robot <hulkci@...wei.com>
Signed-off-by: Zou Wei <zou_wei@...wei.com>
---
 drivers/dma-buf/heaps/system_heap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma-buf/heaps/system_heap.c b/drivers/dma-buf/heaps/system_heap.c
index 0bf688e..41502bf 100644
--- a/drivers/dma-buf/heaps/system_heap.c
+++ b/drivers/dma-buf/heaps/system_heap.c
@@ -20,7 +20,7 @@
 
 #include "heap-helpers.h"
 
-struct dma_heap *sys_heap;
+static struct dma_heap *sys_heap;
 
 static void system_heap_free(struct heap_helper_buffer *buffer)
 {
-- 
2.6.2