linux-kernel - Re: [PATCH 0/8] Style and small fixes for core-scheduling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6de890917af3a3aa6544f5d7c892455f71964c44.camel@gmail.com>
Date:   Wed, 28 Oct 2020 11:58:34 -0700
From:   John Wyatt <jbwyatt4@...il.com>
To:     Phil Auld <pauld@...hat.com>
Cc:     "' Joel Fernandes (Google)" <joel@...lfernandes.org>,
        Nishanth Aravamudan <naravamudan@...italocean.com>,
        Julien Desfossez <jdesfossez@...italocean.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Tim Chen <tim.c.chen@...ux.intel.com>,
        Vineeth Pillai <viremana@...ux.microsoft.com>,
        Aaron Lu <aaron.lwe@...il.com>,
        Aubrey Li <aubrey.intel@...il.com>, tglx@...utronix.de,
        linux-kernel@...r.kernel.org, mingo@...nel.org,
        torvalds@...ux-foundation.org, fweisbec@...il.com,
        keescook@...omium.org, kerrnel@...gle.com,
        Valentin Schneider <valentin.schneider@....com>,
        Mel Gorman <mgorman@...hsingularity.net>,
        Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>,
        Paolo Bonzini <pbonzini@...hat.com>, vineeth@...byteword.org,
        Chen Yu <yu.c.chen@...el.com>,
        Christian Brauner <christian.brauner@...ntu.com>,
        Agata Gruza <agata.gruza@...el.com>,
        Antonio Gomez Iglesias <antonio.gomez.iglesias@...el.com>,
        graf@...zon.com, konrad.wilk@...cle.com, dfaggioli@...e.com,
        pjt@...gle.com, rostedt@...dmis.org, derkling@...gle.com,
        benbjiang@...cent.com,
        Alexandre Chartre <alexandre.chartre@...cle.com>,
        James.Bottomley@...senpartnership.com, OWeisse@...ch.edu,
        Dhaval Giani <dhaval.giani@...cle.com>,
        Junaid Shahid <junaids@...gle.com>, jsbarnes@...gle.com,
        chris.hyser@...cle.com, Aubrey Li <aubrey.li@...ux.intel.com>,
        "Paul E. McKenney" <paulmck@...nel.org>,
        Tim Chen ' <tim.c.chen@...el.com>
Subject: Re: [PATCH 0/8] Style and small fixes for core-scheduling

Hi Phil,

> Hi John,
> 
> Welcome!

Thank you!

> 
> > Please feel free to advise on any corrections or improvements that
> > can be
> > made.
> 
> Thanks for these. I wonder, though, if it would not make more sense
> to post these changes as comments on the original as-yet-unmerged
> patches that you are fixing up? 

Patch 23/26 has a lot of spaces to tabs issues that are isolated to one
file (and one patch if I read it correctly). It would definitely make
sense for those to be a comment. Especially with patch 23 being a later
patch in the patch series. Most of those issues are not fixed by this
patch series I submitted.

For the rest, I am willing to do resubmit as comments if that would be
easier for the submitter.

Please let me know if that is how I should resubmit them.

Being a patch set does makes them easier to verify. Some warnings
against the individual patches, like braces surrounding a one line in a
if block, disappear with later patches as the code is added. For
clarity for the mailing list, I used the jfern tree with the
'coresched-v8-posted-to-list'.

https://git.kernel.org/pub/scm/linux/kernel/git/jfern/linux.git/tag/?h=coresched-v8-posted-to-list

Thank you for your feedback.

-- 
Sincerely,
John Wyatt