linux-kernel - Re: [PATCH v2] sched/fair: prefer prev cpu in asymmetric wakeup path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 29 Oct 2020 12:24:45 +0000
From:   Valentin Schneider <valentin.schneider@....com>
To:     Tao Zhou <ouwen210@...mail.com>
Cc:     Vincent Guittot <vincent.guittot@...aro.org>, mingo@...hat.com,
        peterz@...radead.org, juri.lelli@...hat.com,
        dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
        mgorman@...e.de, linux-kernel@...r.kernel.org,
        morten.rasmussen@....com
Subject: Re: [PATCH v2] sched/fair: prefer prev cpu in asymmetric wakeup path


On 29/10/20 12:17, Tao Zhou wrote:
> Hi Vincent,
>
> On Wed, Oct 28, 2020 at 06:44:12PM +0100, Vincent Guittot wrote:
>> @@ -6173,20 +6173,20 @@ static int
>>  select_idle_capacity(struct task_struct *p, struct sched_domain *sd, int target)
>>  {
>>      unsigned long best_cap = 0;
>> -	int cpu, best_cpu = -1;
>> +	int task_util, cpu, best_cpu = -1;
>>      struct cpumask *cpus;
>>
>> -	sync_entity_load_avg(&p->se);
>> -
>>      cpus = this_cpu_cpumask_var_ptr(select_idle_mask);
>>      cpumask_and(cpus, sched_domain_span(sd), p->cpus_ptr);
>>
>> +	task_util = uclamp_task_util(p);
>
> The return type of uclamp_task_util() is *unsigned long*.
> But, task_util is *int*.
>
> @Valentin: I checked that the return type of uclamp_task_util()
> is changed from unsigned int to unsigned long by you
>

Indeed, IIRC I stated in that changelog that the canonical type for
utilization / capacity values is unsigned long.