linux-kernel - Re: [PATCH -next] drm/i915: Remove unused variable ret

Open Source and information security mailing list archives

Message-ID: <20201029132743.GZ6112@intel.com>
Date:   Thu, 29 Oct 2020 15:27:43 +0200
From:   Ville Syrjälä <ville.syrjala@...ux.intel.com>
To:     Zou Wei <zou_wei@...wei.com>
Cc:     jani.nikula@...ux.intel.com, joonas.lahtinen@...ux.intel.com,
        rodrigo.vivi@...el.com, airlied@...ux.ie, daniel@...ll.ch,
        intel-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH -next] drm/i915: Remove unused variable ret

On Thu, Oct 29, 2020 at 10:18:45AM +0800, Zou Wei wrote:
> This patch fixes below warnings reported by coccicheck
> 
> ./drivers/gpu/drm/i915/i915_debugfs.c:789:5-8: Unneeded variable: "ret". Return "0" on line 1012
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zou Wei <zou_wei@...wei.com>

Thanks. Applied.

> ---
>  drivers/gpu/drm/i915/i915_debugfs.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index ea46916..200f6b8 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -786,7 +786,6 @@ static int i915_frequency_info(struct seq_file *m, void *unused)
>  	struct intel_uncore *uncore = &dev_priv->uncore;
>  	struct intel_rps *rps = &dev_priv->gt.rps;
>  	intel_wakeref_t wakeref;
> -	int ret = 0;
>  
>  	wakeref = intel_runtime_pm_get(&dev_priv->runtime_pm);
>  
> @@ -1009,7 +1008,7 @@ static int i915_frequency_info(struct seq_file *m, void *unused)
>  	seq_printf(m, "Max pixel clock frequency: %d kHz\n", dev_priv->max_dotclk_freq);
>  
>  	intel_runtime_pm_put(&dev_priv->runtime_pm, wakeref);
> -	return ret;
> +	return 0;
>  }
>  
>  static int i915_ring_freq_table(struct seq_file *m, void *unused)
> -- 
> 2.6.2
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Ville Syrjälä
Intel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives