lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 29 Oct 2020 22:23:25 +0800 From: Coiby Xu <coiby.xu@...il.com> To: Robin Murphy <robin.murphy@....com> Cc: Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." <alsa-devel@...a-project.org>, Heiko Stuebner <heiko@...ech.de>, Liam Girdwood <lgirdwood@...il.com>, open list <linux-kernel@...r.kernel.org>, "open list:ARM/Rockchip SoC support" <linux-rockchip@...ts.infradead.org>, Mark Brown <broonie@...nel.org>, "moderated list:ARM/Rockchip SoC support" <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH 04/25] ASoC: rockchip: remove unnecessary CONFIG_PM_SLEEP On Thu, Oct 29, 2020 at 10:33:52AM +0000, Robin Murphy wrote: >On 2020-10-29 07:42, Coiby Xu wrote: >>SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG. > >I don't see anything in the !CONFIG_PM_CONFIG side of >SET_SYSTEM_SLEEP_PM_OPS() that prevents unused function warnings for >the callbacks - does this change depend on some other patch or is it >just wrong? > Thank you for the feedback! I'll add "__maybe_unused" in v2. >Robin. > >>Signed-off-by: Coiby Xu <coiby.xu@...il.com> >>--- >> sound/soc/rockchip/rockchip_pdm.c | 2 -- >> 1 file changed, 2 deletions(-) >> >>diff --git a/sound/soc/rockchip/rockchip_pdm.c b/sound/soc/rockchip/rockchip_pdm.c >>index 5adb293d0435..f3c19310aeeb 100644 >>--- a/sound/soc/rockchip/rockchip_pdm.c >>+++ b/sound/soc/rockchip/rockchip_pdm.c >>@@ -574,7 +574,6 @@ static int rockchip_pdm_remove(struct platform_device *pdev) >> return 0; >> } >>-#ifdef CONFIG_PM_SLEEP >> static int rockchip_pdm_suspend(struct device *dev) >> { >> struct rk_pdm_dev *pdm = dev_get_drvdata(dev); >>@@ -601,7 +600,6 @@ static int rockchip_pdm_resume(struct device *dev) >> return ret; >> } >>-#endif >> static const struct dev_pm_ops rockchip_pdm_pm_ops = { >> SET_RUNTIME_PM_OPS(rockchip_pdm_runtime_suspend, >> -- Best regards, Coiby
Powered by blists - more mailing lists