linux-kernel - Re: [PATCH 01/15] iio: accel: remove unnecessary CONFIG_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201029144007.77d967b0@archlinux>
Date:   Thu, 29 Oct 2020 14:40:07 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Coiby Xu <coiby.xu@...il.com>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        linux-iio@...r.kernel.org (open list:IIO SUBSYSTEM AND DRIVERS),
        linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCH 01/15] iio: accel: remove unnecessary CONFIG_PM_SLEEP

On Thu, 29 Oct 2020 15:48:56 +0800
Coiby Xu <coiby.xu@...il.com> wrote:

> SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG.
> 
> Signed-off-by: Coiby Xu <coiby.xu@...il.com>
Hi Coiby, 

Please put a cover letter on your next series explaining the context.
In this particular case some of the replies you have gotten are
general at it is a lot easier to find these sorts of things via
replying to the cover letter.

Jonathan

> ---
>  drivers/iio/accel/da311.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/iio/accel/da311.c b/drivers/iio/accel/da311.c
> index 3b3df620ba27..55d4891556ca 100644
> --- a/drivers/iio/accel/da311.c
> +++ b/drivers/iio/accel/da311.c
> @@ -263,7 +263,6 @@ static int da311_remove(struct i2c_client *client)
>  	return da311_enable(client, false);
>  }
>  
> -#ifdef CONFIG_PM_SLEEP
>  static int da311_suspend(struct device *dev)
>  {
>  	return da311_enable(to_i2c_client(dev), false);
> @@ -273,7 +272,6 @@ static int da311_resume(struct device *dev)
>  {
>  	return da311_enable(to_i2c_client(dev), true);
>  }
> -#endif
>  
>  static SIMPLE_DEV_PM_OPS(da311_pm_ops, da311_suspend, da311_resume);
>