linux-kernel - Re: [RESEND PATCH 2/4] usb: musb: Fix NULL check on struct musb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 29 Oct 2020 16:58:53 +0200
From:   Tony Lindgren <tony@...mide.com>
To:     Paul Cercueil <paul@...pouillou.net>
Cc:     Bin Liu <b-liu@...com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>, od@...c.me,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Maarten ter Huurne <maarten@...ewalker.org>
Subject: Re: [RESEND PATCH 2/4] usb: musb: Fix NULL check on struct
 musb_request field

* Paul Cercueil <paul@...pouillou.net> [201027 16:42]:
> The 'request' variable is a pointer to the 'request' field of the
> struct musb_request 'req' pointer. It only worked until now because
> the 'request' field is the first one in the musb_request structure, but
> as soon as that changes, the check will be invalid.
> 
> Fix it preventively by doing the NULL-check on the 'req' pointer
> instead.

Acked-by: Tony Lindgren <tony@...mide.com>