linux-kernel - Re: [PATCH v3] AMD_SFH: Fix for incorrect Sensor index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 29 Oct 2020 16:03:16 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Sandeep Singh <Sandeep.Singh@....com>
cc:     benjamin.tissoires@...hat.com, linux-kernel@...r.kernel.org,
        linux-input@...r.kernel.org, jic23@...nel.org,
        Nehal-bakulchandra.Shah@....com, mail@...hard-neumann.de,
        Shyam-sundar.S-k@....com, lipheng@...mail.net
Subject: Re: [PATCH v3] AMD_SFH: Fix for incorrect Sensor index

On Wed, 28 Oct 2020, Sandeep Singh wrote:

> From: Sandeep Singh <sandeep.singh@....com>
> 
> It appears like the accelerometer/magnetometer and gyroscope
> indices were interchanged in the patch series which got into
> for-5.11/amd-sfh-hid until Mandoli/Richard reported to us.
> Ideally sensor indices should be 0,1,2 for the accelerometer,
> Gyroscope, Magnetometer respectively, but this interchanged
> possibly could be because i was using a test MP2 firmware
> on my machine.
> 
> This patch fixes the earlier commit with the right sensor
> indices and also removing unused structures
> _hid_report_descriptor,
> _hid_device_descriptor as reported by Richard.
> 
> Reported-by: Mandoli <lipheng@...mail.net>
> Reported-by: Richard Neumann <mail@...hard-neumann.de>
> Signed-off-by: Sandeep Singh <sandeep.singh@....com>
> Fixes: SFH: PCIe driver to add support of AMD sensor fusion hub (4f567b9f8141)

I've modified the Fixes: tag so that it has proper format and applied, 
thanks.

-- 
Jiri Kosina
SUSE Labs