linux-kernel - Re: [PATCH] regmap: provide regmap_assign

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201029151847.GB5042@sirena.org.uk>
Date:   Thu, 29 Oct 2020 15:18:47 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     linux-kernel@...r.kernel.org,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Subject: Re: [PATCH] regmap: provide regmap_assign_bits()

On Mon, Oct 26, 2020 at 04:10:15PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@...libre.com>
> 
> Add another bits helper to regmap API: this one sets given bits if value
> is true and clears them if it's false.

What's the use case?

> +static inline int regmap_assign_bits(struct regmap *map, unsigned int reg,
> +				     unsigned int bits, bool value)

I don't have a great suggestion but this naming feels prone to confusion
with _update_bits().  

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)