| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 29 Oct 2020 17:42:15 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Pavel Machek <pavel@....cz>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Lars-Peter Clausen <lars@...afoo.de>,
Tianshu Qiu <tian.shu.qiu@...el.com>,
Dongchun Zhu <dongchun.zhu@...iatek.com>,
Shawn Tu <shawnx.tu@...el.com>,
Ricardo Ribalda <ribalda@...nel.org>,
Dave Stevenson <dave.stevenson@...pberrypi.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
Bingbu Cao <bingbu.cao@...el.com>,
Rui Miguel Silva <rmfrfs@...il.com>,
Shunqian Zheng <zhengsq@...k-chips.com>,
Chiranjeevi Rapolu <chiranjeevi.rapolu@...el.com>,
Hyungwoo Yang <hyungwoo.yang@...el.com>,
Wenyou Yang <wenyou.yang@...rochip.com>,
Hans Verkuil <hverkuil-cisco@...all.nl>,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Krzysztof Kozlowski <krzk@...nel.org>
Subject: [RESEND PATCH 01/25] media: i2c: imx214: simplify getting state container
The pointer to 'struct v4l2_subdev' is stored in drvdata via
v4l2_i2c_subdev_init() so there is no point of a dance like:
struct i2c_client *client = to_i2c_client(struct device *dev)
struct v4l2_subdev *sd = i2c_get_clientdata(client);
This allows to remove local variable 'client' and few pointer
dereferences. White at it, use 'dev' directly instead of 'imx214->dev'.
Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
---
drivers/media/i2c/imx214.c | 16 ++++++----------
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c
index 1ef5af9a8c8b..dc27c3678f18 100644
--- a/drivers/media/i2c/imx214.c
+++ b/drivers/media/i2c/imx214.c
@@ -431,14 +431,13 @@ static inline struct imx214 *to_imx214(struct v4l2_subdev *sd)
static int __maybe_unused imx214_power_on(struct device *dev)
{
- struct i2c_client *client = to_i2c_client(dev);
- struct v4l2_subdev *sd = i2c_get_clientdata(client);
+ struct v4l2_subdev *sd = dev_get_drvdata(dev);
struct imx214 *imx214 = to_imx214(sd);
int ret;
ret = regulator_bulk_enable(IMX214_NUM_SUPPLIES, imx214->supplies);
if (ret < 0) {
- dev_err(imx214->dev, "failed to enable regulators: %d\n", ret);
+ dev_err(dev, "failed to enable regulators: %d\n", ret);
return ret;
}
@@ -447,7 +446,7 @@ static int __maybe_unused imx214_power_on(struct device *dev)
ret = clk_prepare_enable(imx214->xclk);
if (ret < 0) {
regulator_bulk_disable(IMX214_NUM_SUPPLIES, imx214->supplies);
- dev_err(imx214->dev, "clk prepare enable failed\n");
+ dev_err(dev, "clk prepare enable failed\n");
return ret;
}
@@ -459,8 +458,7 @@ static int __maybe_unused imx214_power_on(struct device *dev)
static int __maybe_unused imx214_power_off(struct device *dev)
{
- struct i2c_client *client = to_i2c_client(dev);
- struct v4l2_subdev *sd = i2c_get_clientdata(client);
+ struct v4l2_subdev *sd = dev_get_drvdata(dev);
struct imx214 *imx214 = to_imx214(sd);
gpiod_set_value_cansleep(imx214->enable_gpio, 0);
@@ -910,8 +908,7 @@ static int imx214_parse_fwnode(struct device *dev)
static int __maybe_unused imx214_suspend(struct device *dev)
{
- struct i2c_client *client = to_i2c_client(dev);
- struct v4l2_subdev *sd = i2c_get_clientdata(client);
+ struct v4l2_subdev *sd = dev_get_drvdata(dev);
struct imx214 *imx214 = to_imx214(sd);
if (imx214->streaming)
@@ -922,8 +919,7 @@ static int __maybe_unused imx214_suspend(struct device *dev)
static int __maybe_unused imx214_resume(struct device *dev)
{
- struct i2c_client *client = to_i2c_client(dev);
- struct v4l2_subdev *sd = i2c_get_clientdata(client);
+ struct v4l2_subdev *sd = dev_get_drvdata(dev);
struct imx214 *imx214 = to_imx214(sd);
int ret;
--
2.25.1
Powered by blists - more mailing lists