linux-kernel - Re: [PATCH v2] input: add 2 kind of switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201029174524.GC2547185@dtor-ws>
Date:   Thu, 29 Oct 2020 10:45:24 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Cc:     HyungJae Im <hj2.im@...sung.com>,
        "manivannan.sadhasivam@...aro.org" <manivannan.sadhasivam@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "rydberg@...math.org" <rydberg@...math.org>,
        Jungrae Kim <jryu.kim@...sung.com>
Subject: Re: [PATCH v2] input: add 2 kind of switch

On Thu, Oct 29, 2020 at 02:57:15PM +0100, gregkh@...uxfoundation.org wrote:
> On Thu, Oct 29, 2020 at 10:27:47PM +0900, HyungJae Im wrote:
> > From: "hj2.im" <hj2.im@...sung.com>
> > Date: Thu, 29 Oct 2020 22:11:24 +0900
> > Subject: [PATCH v2] input: add 2 kind of switch
> 
> Why is this in the body of that patch?
> 
> > 
> > We need support to various accessories on the device,
> > some switch does not exist in switch list.
> > So added switch for the following purpose.
> > 
> > SW_COVER_ATTACHED is for the checking the cover
> > attached or not on the device. SW_EXT_PEN_ATTACHED is for the
> > checking the external pen attached or not on the device
> 
> You didn't answer the previous question as to why the existing values do
> not work for you instead of having to create new ones?
> 
> 
> > 
> > Signed-off-by: Hyungjae Im <hj2.im@...sung.com>
> > ---
> >  drivers/input/Kconfig                  |  20 ++
> >  drivers/input/Makefile                 |   3 +
> >  drivers/input/cover_detect.c           | 242 ++++++++++++++++++++++++
> >  drivers/input/ext_pen_detect.c         | 243 +++++++++++++++++++++++++
> >  include/linux/mod_devicetable.h        |   2 +-
> >  include/uapi/linux/input-event-codes.h |   4 +-
> >  6 files changed, 512 insertions(+), 2 deletions(-)
> >  create mode 100644 drivers/input/cover_detect.c
> >  create mode 100644 drivers/input/ext_pen_detect.c
> 
> If this is v2, what changed from v1?
> 
> And this is 2 different drivers, it should be 2 different patches at the
> least, right?>

Actually the should simply use gpio-keys.c for this and dispense with
the custom drivers.

Thanks.

-- 
Dmitry