linux-kernel - Re: [PATCH] leds: various: add missing put_device() call in netxbig_leds_get_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201029174952.GB26053@duo.ucw.cz>
Date:   Thu, 29 Oct 2020 18:49:52 +0100
From:   Pavel Machek <pavel@....cz>
To:     Yu Kuai <yukuai3@...wei.com>
Cc:     linus.walleij@...aro.org, j.anaszewski@...sung.com,
        simon.guinot@...uanux.org, linux-leds@...r.kernel.org,
        linux-kernel@...r.kernel.org, yi.zhang@...wei.com
Subject: Re: [PATCH] leds: various: add missing put_device() call in
 netxbig_leds_get_of_pdata()

Hi!

> if of_find_device_by_node() succeed, netxbig_leds_get_of_pdata() doesn't
> have a corresponding put_device(). Thus add jump target to fix the
> exception handling for this function implementation.
> 
> Fixes: 2976b1798909 ("leds: netxbig: add device tree binding")
> Signed-off-by: Yu Kuai <yukuai3@...wei.com>

Thanks, applied.

But it seems to me similar handling is needed in "success" paths, no?

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)