linux-kernel - Re: [PATCH 1/3] Input: pmic8xxx-keypad: remove unnecessary CONFIG_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201029175256.GD2547185@dtor-ws>
Date:   Thu, 29 Oct 2020 10:52:56 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Coiby Xu <coiby.xu@...il.com>
Cc:     "open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)..." 
        <linux-input@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] Input: pmic8xxx-keypad: remove unnecessary
 CONFIG_PM_SLEEP

On Thu, Oct 29, 2020 at 03:52:34PM +0800, Coiby Xu wrote:
> SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG.

Doesn't it result in "defined but not used" warnings if you compile
without CONFIG_PM? I believe if you are dropping #ifdef guards you need
to add __maybe_unused annotations.

> Signed-off-by: Coiby Xu <coiby.xu@...il.com>
> ---
>  drivers/input/keyboard/pmic8xxx-keypad.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/input/keyboard/pmic8xxx-keypad.c b/drivers/input/keyboard/pmic8xxx-keypad.c
> index 91d5811d6f0e..c04ab04331b2 100644
> --- a/drivers/input/keyboard/pmic8xxx-keypad.c
> +++ b/drivers/input/keyboard/pmic8xxx-keypad.c
> @@ -621,7 +621,6 @@ static int pmic8xxx_kp_probe(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -#ifdef CONFIG_PM_SLEEP
>  static int pmic8xxx_kp_suspend(struct device *dev)
>  {
>  	struct platform_device *pdev = to_platform_device(dev);
> @@ -661,7 +660,6 @@ static int pmic8xxx_kp_resume(struct device *dev)
>  
>  	return 0;
>  }
> -#endif
>  
>  static SIMPLE_DEV_PM_OPS(pm8xxx_kp_pm_ops,
>  			 pmic8xxx_kp_suspend, pmic8xxx_kp_resume);
> -- 
> 2.28.0
> 

Thanks.

-- 
Dmitry