linux-kernel - Re: [PATCH 1/9] mfd: maxim: remove unnecessary CONFIG_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Oct 2020 19:32:26 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Coiby Xu <coiby.xu@...il.com>
Cc:     Lee Jones <lee.jones@...aro.org>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        "open list:MAXIM PMIC AND MUIC DRIVERS FOR EXYNOS BASED BO..." 
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/9] mfd: maxim: remove unnecessary CONFIG_PM_SLEEP

On Thu, Oct 29, 2020 at 06:06:39PM +0800, Coiby Xu wrote:
> SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG.

I don't quite get what did you mean by "took good care". This should
cause warnings of unused structure.  Comment applies to other patches as
well.

Also, the title prefix is: "mfd: max77686:"

Best regards,
Krzysztof


> 
> Signed-off-by: Coiby Xu <coiby.xu@...il.com>
> ---
>  drivers/mfd/max77686.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c
> index 71faf503844b..8c701f8a9dd5 100644
> --- a/drivers/mfd/max77686.c
> +++ b/drivers/mfd/max77686.c
> @@ -227,7 +227,6 @@ static int max77686_i2c_probe(struct i2c_client *i2c)
>  	return 0;
>  }
>  
> -#ifdef CONFIG_PM_SLEEP
>  static int max77686_suspend(struct device *dev)
>  {
>  	struct i2c_client *i2c = to_i2c_client(dev);
> @@ -262,7 +261,6 @@ static int max77686_resume(struct device *dev)
>  
>  	return 0;
>  }
> -#endif /* CONFIG_PM_SLEEP */
>  
>  static SIMPLE_DEV_PM_OPS(max77686_pm, max77686_suspend, max77686_resume);
>  
> -- 
> 2.28.0
>