linux-kernel - Re: [PATCH] ASoC: samsung: i2s: Remove redundant null check before clk_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201029183651.GA90952@kozik-lap>
Date:   Thu, 29 Oct 2020 19:36:51 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Xu Wang <vulab@...as.ac.cn>
Cc:     sbkim73@...sung.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: samsung: i2s: Remove redundant null check before
 clk_disable_unprepare

On Thu, Oct 29, 2020 at 08:37:15AM +0000, Xu Wang wrote:
> Because clk_disable_unprepare() already checked NULL clock parameter,
> so the additional check is unnecessary, just remove it.

You missed other places with it - the resume part.

Best regards,
Krzysztof

> 
> Signed-off-by: Xu Wang <vulab@...as.ac.cn>
> ---
>  sound/soc/samsung/i2s.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)