linux-kernel - Re: [PATCH] drm/hisilicon: Adding a const declaration to an invariant construct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 29 Oct 2020 20:13:07 +0100
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Tian Tao <tiantao6@...ilicon.com>, airlied@...ux.ie,
        daniel@...ll.ch, kraxel@...hat.com, alexander.deucher@....com,
        tglx@...utronix.de, dri-devel@...ts.freedesktop.org,
        xinliang.liu@...aro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/hisilicon: Adding a const declaration to an invariant
 construct

Hi

Am 29.10.20 um 08:11 schrieb Tian Tao:
> Some constructs cannot be changed after being assigned a value,
> so add const declarations to invariant constructs.
> 
> Signed-off-by: Tian Tao <tiantao6@...ilicon.com>

Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>

> ---
>  drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c  | 2 +-
>  drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c
> index a1eabad..ef18b47 100644
> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c
> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c
> @@ -139,7 +139,7 @@ static const u32 channel_formats1[] = {
>  	DRM_FORMAT_ABGR8888
>  };
>  
> -static struct drm_plane_funcs hibmc_plane_funcs = {
> +static const struct drm_plane_funcs hibmc_plane_funcs = {
>  	.update_plane	= drm_atomic_helper_update_plane,
>  	.disable_plane	= drm_atomic_helper_disable_plane,
>  	.destroy = drm_plane_cleanup,
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> index 0c1b40d..fee6fe8 100644
> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> @@ -369,7 +369,7 @@ static void hibmc_pci_remove(struct pci_dev *pdev)
>  	drm_dev_put(dev);
>  }
>  
> -static struct pci_device_id hibmc_pci_table[] = {
> +static const struct pci_device_id hibmc_pci_table[] = {
>  	{ PCI_VDEVICE(HUAWEI, 0x1711) },
>  	{0,}
>  };
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

Download attachment "OpenPGP_0x680DC11D530B7A23.asc" of type "application/pgp-keys" (4202 bytes)

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (496 bytes)