linux-kernel - Re: [PATCH v3 31/56] usb: dwc3: fix kernel-doc markups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Oct 2020 11:13:34 +0200
From:   Felipe Balbi <balbi@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        Linux Doc Mailing List <linux-doc@...r.kernel.org>,
        Jonathan Corbet <corbet@....net>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v3 31/56] usb: dwc3: fix kernel-doc markups

Greg Kroah-Hartman <gregkh@...uxfoundation.org> writes:

> On Tue, Oct 27, 2020 at 08:58:47AM +0200, Felipe Balbi wrote:
>> 
>> Hi Mauro,
>> 
>> Mauro Carvalho Chehab <mchehab+huawei@...nel.org> writes:
>> > There is a common comment marked, instead, with kernel-doc
>> > notation.
>> >
>> > Also, some identifiers have different names between their
>> > prototypes and the kernel-doc markup.
>> >
>> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
>> > ---
>> >  drivers/usb/dwc3/core.c        | 2 +-
>> >  drivers/usb/dwc3/core.h        | 2 +-
>> >  drivers/usb/gadget/composite.c | 2 +-
>> >  drivers/usb/typec/mux.c        | 2 +-
>> >  include/linux/usb/composite.h  | 2 +-
>> 
>> mind breaking this into 4 commits? One for dwc3, one for
>> gadget/composite, one for type/mux, and a final for composite.h.
>
> I'll just take these all at once, it's easy enough :)

Sure thing, in that case:

Acked-by: Felipe Balbi <balbi@...nel.org>

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (858 bytes)