linux-kernel - Re: [PATCH v2] libata: Fix retrieving of active qcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Oct 2020 14:55:14 +0100
From:   Pali Rohár <pali@...nel.org>
To:     Sascha Hauer <s.hauer@...gutronix.de>, Jens Axboe <axboe@...nel.dk>
Cc:     linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...gutronix.de
Subject: Re: [PATCH v2] libata: Fix retrieving of active qcs

On Friday 08 May 2020 07:46:44 Sascha Hauer wrote:
> From fcdcfa9e7a4ee4faf411de1df4f3c4e12c78545c Mon Sep 17 00:00:00 2001
> From: Sascha Hauer <s.hauer@...gutronix.de>
> Date: Fri, 8 May 2020 07:28:19 +0200
> Subject: [PATCH] ata: sata_nv: Fix retrieving of active qcs
> 
> ata_qc_complete_multiple() has to be called with the tags physically
> active, that is the hw tag is at bit 0. ap->qc_active has the same tag
> at bit ATA_TAG_INTERNAL instead, so call ata_qc_get_active() to fix that
> up. This is done in the vein of 8385d756e114 ("libata: Fix retrieving of
> active qcs").
> 
> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>

I tested this second change on nforce4 box with sata_nv controllers:

  00:07.0 IDE interface [0101]: NVIDIA Corporation CK804 Serial ATA Controller [10de:0054] (rev f3)
  00:08.0 IDE interface [0101]: NVIDIA Corporation CK804 Serial ATA Controller [10de:0055] (rev f3)

Both disks are working fine, I do not see any regression or change, so
you can add my:

Tested-by: Pali Rohár <pali@...nel.org>

Ideally add also Fixes line:

Fixes: 28361c403683 ("libata: add extra internal command")

Jens, do you need something more from me? Some special tests, etc?

> ---
>  drivers/ata/sata_nv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/sata_nv.c b/drivers/ata/sata_nv.c
> index eb9dc14e5147..20190f66ced9 100644
> --- a/drivers/ata/sata_nv.c
> +++ b/drivers/ata/sata_nv.c
> @@ -2100,7 +2100,7 @@ static int nv_swncq_sdbfis(struct ata_port *ap)
>  	pp->dhfis_bits &= ~done_mask;
>  	pp->dmafis_bits &= ~done_mask;
>  	pp->sdbfis_bits |= done_mask;
> -	ata_qc_complete_multiple(ap, ap->qc_active ^ done_mask);
> +	ata_qc_complete_multiple(ap, ata_qc_get_active(ap) ^ done_mask);
>  
>  	if (!ap->qc_active) {
>  		DPRINTK("over\n");
> -- 
> 2.26.2