linux-kernel - Re: [PATCH] selftests: intel_pstate: ftime() is deprecated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d4adb97b3325ac93295d5e42dc07e8381fb9efab.camel@nokia.com>
Date:   Wed, 28 Oct 2020 07:36:32 +0000
From:   "Rantala, Tommi T. (Nokia - FI/Espoo)" <tommi.t.rantala@...ia.com>
To:     "shuah@...nel.org" <shuah@...nel.org>,
        "skhan@...uxfoundation.org" <skhan@...uxfoundation.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] selftests: intel_pstate: ftime() is deprecated

On Tue, 2020-10-27 at 14:08 -0600, Shuah Khan wrote:
> 
> > @@ -73,8 +80,8 @@ int main(int argc, char **argv) {
> >   	aperf = new_aperf-old_aperf;
> >   	mperf = new_mperf-old_mperf;
> >   
> > -	start = before.time*1000 + before.millitm;
> > -	finish = after.time*1000 + after.millitm;
> > +	start = before.tv_sec*1000 + before.tv_nsec/1000000L;
> > +	finish = after.tv_sec*1000 + after.tv_nsec/1000000L;
> 
> Why not use timespec dNSEC_PER_MSEC define from  include/vdso/time64.h?

Hi,

If the define was available in the UAPI headers, then certainly would make
sense to use it. But I would not mess with the kernel internal headers here.

-Tommi