linux-kernel - Re: [PATCH v2] efi/libstub: EFI_GENERIC_STUB_INITRD_CMDLINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMj1kXFtmfBVhGQKuiCxHsJcA614=jKnhJuAG2z5HUu7ri9EPg@mail.gmail.com>
Date:   Wed, 28 Oct 2020 16:54:28 +0100
From:   Ard Biesheuvel <ardb@...nel.org>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Ingo Molnar <mingo@...nel.org>,
        Arvind Sankar <nivedita@...m.mit.edu>,
        linux-efi <linux-efi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] efi/libstub: EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER
 should not default to yes

On Wed, 28 Oct 2020 at 16:34, Geert Uytterhoeven
<geert+renesas@...der.be> wrote:
>
> EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER is deprecated, so it should not
> be enabled by default.
>
> In light of commit 4da0b2b7e67524cc ("efi/libstub: Re-enable command
> line initrd loading for x86"), keep the default for X86.
>
> Fixes: cf6b83664895a5c7 ("efi/libstub: Make initrd file loader configurable")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> Hopefully kernelCI has updated its QEMU firmware since v1 was posted...

Yes it has!

>
> v2:
>   - Rebase on top of commit d7071743db31b4f6 ("RISC-V: Add EFI stub
>     support.") in v5.10-rc1.

Thanks, I'll queue this up

> ---
>  drivers/firmware/efi/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
> index 36ec1f7188934ca4..b452cfa2100b401c 100644
> --- a/drivers/firmware/efi/Kconfig
> +++ b/drivers/firmware/efi/Kconfig
> @@ -122,7 +122,7 @@ config EFI_ARMSTUB_DTB_LOADER
>  config EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER
>         bool "Enable the command line initrd loader" if !X86
>         depends on EFI_STUB && (EFI_GENERIC_STUB || X86)
> -       default y
> +       default y if X86
>         depends on !RISCV
>         help
>           Select this config option to add support for the initrd= command
> --
> 2.25.1
>