linux-kernel - Re: [PATCH] ext4: properly check for dirty state in ext4_inode_datasync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 28 Oct 2020 10:03:01 +0530
From:   Ritesh Harjani <riteshh@...ux.ibm.com>
To:     harshad shirwadkar <harshadshirwadkar@...il.com>
Cc:     Andrea Righi <andrea.righi@...onical.com>,
        "Theodore Ts'o" <tytso@....edu>,
        Andreas Dilger <adilger.kernel@...ger.ca>,
        Ext4 Developers List <linux-ext4@...r.kernel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ext4: properly check for dirty state in
 ext4_inode_datasync_dirty()



On 10/28/20 9:18 AM, harshad shirwadkar wrote:
> Actually the simpler fix for this in case of fast commits is to check
> if the inode is on the fast commit list or not. Since we clear the
> fast commit list after every fast and / or full commit, it's always
> true that if the inode is not on the list, that means it isn't dirty.
> This will simplify the logic here and then we can probably get rid of
> i_fc_committed_subtid field altogether. I'll test this and send out a
> patch.

Yes, sounds like a better solution. Thanks!

-ritesh