linux-kernel - RE: [PATCH V3 1/1] nvme: Add quirk for LiteON CL1 devices running FW 220TQ,22001

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <HK2PR02MB4004EC30D14A16B59FD22A44EE140@HK2PR02MB4004.apcprd02.prod.outlook.com>
Date:   Thu, 29 Oct 2020 02:20:27 +0000
From:   Gloria Tsai <Gloria.Tsai@...tc.com>
To:     Christoph Hellwig <hch@....de>, Jongpil Jung <jongpuls@...il.com>
CC:     Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...com>,
        Sagi Grimberg <sagi@...mberg.me>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jongpil19.jung@...sung.com" <jongpil19.jung@...sung.com>,
        "jongheony.kim@...sung.com" <jongheony.kim@...sung.com>,
        "dj54.sohn@...sung.com" <dj54.sohn@...sung.com>
Subject: RE: [PATCH V3 1/1] nvme: Add quirk for LiteON CL1 devices running FW
 220TQ,22001

Corrected the description of this bug that SSD will not do GC after receiving shutdown cmd.
Do GC before shutdown -> delete IO Q -> shutdown from host -> breakup GC -> D3hot -> enter PS4 -> have a chance swap block -> use wrong pointer on device SRAM -> over program

SSD gets in low power mode only in suspend, this issue only happens in low power mode. 
As for Hibernate, power off, unbinding the driver or even warm boot, EC boot, SSD won't be in low power state, so there'll be no problem.

Regards,
Gloria Tsai
_____________________________________

Sales PM Division
Solid State Storage Technology Corporation
TEL: +886-3-612-3888 ext. 2201
E-Mail: gloria.tsai@...tc.com
_____________________________________

-----Original Message-----
From: Christoph Hellwig <hch@....de> 
Sent: Thursday, October 29, 2020 1:17 AM
To: Jongpil Jung <jongpuls@...il.com>
Cc: Keith Busch <kbusch@...nel.org>; Jens Axboe <axboe@...com>; Christoph Hellwig <hch@....de>; Sagi Grimberg <sagi@...mberg.me>; linux-nvme@...ts.infradead.org; linux-kernel@...r.kernel.org; Gloria Tsai <Gloria.Tsai@...tc.com>; jongpil19.jung@...sung.com; jongheony.kim@...sung.com; dj54.sohn@...sung.com
Subject: Re: [PATCH V3 1/1] nvme: Add quirk for LiteON CL1 devices running FW 220TQ,22001

This message was sent from outside of the company. Please do not click links or open attachments unless you recognize the source of this email and know the content is safe.

On Wed, Oct 28, 2020 at 06:14:21PM +0900, Jongpil Jung wrote:
> LiteON(SSSTC) CL1 device running FW 220TQ,22001 has bugs with simple 
> suspend.
>
> When NVMe device receive D3hot from host, NVMe firmware will do 
> garbage collection. While NVMe device do Garbage collection, firmware 
> has chance to going incorrect address.

I'm still lost on what this means.  The device doesn't receive 'D3hot'
from the host, it receives a shutdown request.  And we don't just do that when hibernating, but also when doing an actual shutdown, a suspend to disk, unbinding the driver, etc.  So if the device has a problem with shutdowns we really are in trouble.