linux-kernel - Re: [PATCH 2/3] ARM: dts: aspeed: amd-ethanolx: Enable KCS channel 3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5e829382-3a6b-7905-52ea-3ae274dd60b1@amd.com>
Date:   Wed, 28 Oct 2020 10:59:45 -0500
From:   Supreeth Venkatesh <supreeth.venkatesh@....com>
To:     Joel Stanley <joel@....id.au>,
        Konstantin Aladyshev <aladyshev22@...il.com>
Cc:     Rob Herring <robh+dt@...nel.org>, Andrew Jeffery <andrew@...id.au>,
        devicetree <devicetree@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        linux-aspeed <linux-aspeed@...ts.ozlabs.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] ARM: dts: aspeed: amd-ethanolx: Enable KCS channel 3

Thanks Konstantin for this patch.
Thanks Joel for reviewing this.

On 10/28/20 12:28 AM, Joel Stanley wrote:
> [CAUTION: External Email]
> 
> On Tue, 27 Oct 2020 at 12:41, Konstantin Aladyshev
> <aladyshev22@...il.com> wrote:
>>
>> The KCS interface on the LPC channel 3 in the controller
>> is used for the in-band BMC<->BIOS IPMI communication.
>> 0xCA2 is a default host CPU LPC IO address for this
>> interface.
>>
>> Signed-off-by: Konstantin Aladyshev <aladyshev22@...il.com>
> 
> I don't have any docs on the platform so I'll wait for a review from
> Supreeth before applying this one.
Done.
> 
> It's a correct use of the bindings:
> 
> Reviewed-by: Joel Stanley <joel@....id.au>
Reviewed-by: Supreeth Venkatesh <supreeth.venkatesh@....com>

> 
>> ---
>>  arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts b/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
>> index 89ddc3847222..2a86bda8afd8 100644
>> --- a/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
>> +++ b/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
>> @@ -147,6 +147,11 @@
>>         aspeed,lpc-io-reg = <0x62>;
>>  };
>>
>> +&kcs3 {
>> +       status = "okay";
>> +       aspeed,lpc-io-reg = <0xCA2>;
>> +};
>> +
>>  &kcs4 {
>>         status = "okay";
>>         aspeed,lpc-io-reg = <0x97DE>;
>> --
>> 2.17.1
>>