linux-kernel - Re: [PATCH] KUnit: Docs: style: fix some Kconfig example issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <07963645-1644-53c2-b1da-8f89fe865eda@infradead.org>
Date:   Tue, 27 Oct 2020 22:32:26 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     David Gow <davidgow@...gle.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        KUnit Development <kunit-dev@...glegroups.com>,
        Shuah Khan <shuah@...nel.org>,
        Shuah Khan <skhan@...uxfoundation.org>,
        Brendan Higgins <brendanhiggins@...gle.com>
Subject: Re: [PATCH] KUnit: Docs: style: fix some Kconfig example issues

On 10/27/20 8:00 PM, David Gow wrote:
> On Wed, Oct 28, 2020 at 2:49 AM Randy Dunlap <rdunlap@...radead.org> wrote:
>>
>> Fix the Kconfig example to be closer to Kconfig coding style.
>> (Except that it still uses spaces instead of tabs for indentation;
>> I guess that Sphinx wants it that way.)
>>
>> Also add punctuation and a trailing slash ('/') to a sub-directory
>> name -- this is how the text mostly appears in other Kconfig files.
>>
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> Cc: David Gow <davidgow@...gle.com>
>> Cc: linux-kselftest@...r.kernel.org
>> Cc: kunit-dev@...glegroups.com
>> Cc: Shuah Khan <shuah@...nel.org>
>> Cc: Shuah Khan <skhan@...uxfoundation.org>
>> Cc: Brendan Higgins <brendanhiggins@...gle.com>
>> ---
> 
> Thanks for fixing this!
> 
> For what it's worth, I _think_ we could get away with tabs for
> indentation in the file without Sphinx actually complaining, but it
> does annoy some of the editors, and as far as I can tell, Sphinx
> converts them back to spaces in its output. I'm far from an expert,
> though...
> 
> Regardless, this is:
> 
> Reviewed-by: David Gow <davidgow@...gle.com>

I tested with tabs for indentation and it's no problem with Sphinx.
Some editors care?  I am surprised.  and don't much care.

I would be happy to submit a v2 using tabs for indentation.

thanks.
-- 
~Randy