linux-kernel - Re: [PATCH 15/17] phy: phy-stm32-usbphyc: convert to devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <64bc5ff6-5495-30de-108f-80a4a8c54e91@st.com>
Date:   Thu, 29 Oct 2020 11:20:32 +0100
From:   Amelie DELAUNAY <amelie.delaunay@...com>
To:     Chunfeng Yun <chunfeng.yun@...iatek.com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Vinod Koul <vkoul@...nel.org>
CC:     Ondrej Jirman <megous@...ous.com>, Peter Chen <peter.chen@....com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Anil Varughese <aniljoy@...ence.com>,
        Wei Yongjun <weiyongjun1@...wei.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Fabio Estevam <festevam@...il.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Kevin Hilman <khilman@...libre.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Rayagonda Kokatanur <rayagonda.kokatanur@...adcom.com>,
        Chen-Yu Tsai <wens@...e.org>,
        <bcm-kernel-feedback-list@...adcom.com>,
        NXP Linux Team <linux-imx@....com>,
        Icenowy Zheng <icenowy@...c.io>,
        Bharat Gooty <bharat.gooty@...adcom.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Ray Jui <rjui@...adcom.com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Maxime Ripard <mripard@...nel.org>,
        Yue Wang <yue.wang@...ogic.com>,
        Lubomir Rintel <lkundrak@...sk>,
        Remi Pommarel <repk@...plefau.lt>,
        <linux-mediatek@...ts.infradead.org>,
        Rikard Falkeborn <rikard.falkeborn@...il.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        <linux-amlogic@...ts.infradead.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        Roger Quadros <rogerq@...com>,
        Hanjie Lin <hanjie.lin@...ogic.com>,
        Ma Feng <mafeng.ma@...wei.com>,
        Scott Branden <sbranden@...adcom.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Jyri Sarha <jsarha@...com>, <linux-kernel@...r.kernel.org>,
        Sanket Parmar <sparmar@...ence.com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Joe Perches <joe@...ches.com>,
        Colin Ian King <colin.king@...onical.com>,
        Shawn Guo <shawnguo@...nel.org>, Li Jun <jun.li@....com>
Subject: Re: [PATCH 15/17] phy: phy-stm32-usbphyc: convert to
 devm_platform_ioremap_resource



On 10/29/20 3:54 AM, Chunfeng Yun wrote:
> Use devm_platform_ioremap_resource to simplify code
> 
> Signed-off-by: Chunfeng Yun <chunfeng.yun@...iatek.com>

Reviewed-by: Amelie Delaunay <amelie.delaunay@...com>

> ---
>   drivers/phy/st/phy-stm32-usbphyc.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c
> index 2b3639cba51a..0ab18f2078db 100644
> --- a/drivers/phy/st/phy-stm32-usbphyc.c
> +++ b/drivers/phy/st/phy-stm32-usbphyc.c
> @@ -311,7 +311,6 @@ static int stm32_usbphyc_probe(struct platform_device *pdev)
>   	struct stm32_usbphyc *usbphyc;
>   	struct device *dev = &pdev->dev;
>   	struct device_node *child, *np = dev->of_node;
> -	struct resource *res;
>   	struct phy_provider *phy_provider;
>   	u32 version;
>   	int ret, port = 0;
> @@ -322,8 +321,7 @@ static int stm32_usbphyc_probe(struct platform_device *pdev)
>   	usbphyc->dev = dev;
>   	dev_set_drvdata(dev, usbphyc);
>   
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	usbphyc->base = devm_ioremap_resource(dev, res);
> +	usbphyc->base = devm_platform_ioremap_resource(pdev, 0);
>   	if (IS_ERR(usbphyc->base))
>   		return PTR_ERR(usbphyc->base);
>   
>