linux-kernel - Re: [PATCH 3/3] proc: switch over direct seq_read method calls to seq_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201029103255.GD3764182@kroah.com>
Date:   Thu, 29 Oct 2020 11:32:55 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Christoph Hellwig <hch@....de>
Cc:     Al Viro <viro@...iv.linux.org.uk>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Alexey Dobriyan <adobriyan@...il.com>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] proc: switch over direct seq_read method calls to
 seq_read_iter

On Thu, Oct 29, 2020 at 11:09:50AM +0100, Christoph Hellwig wrote:
> Switch over all instances used directly as methods using these sed
> expressions:
> 
> sed -i -e 's/\.proc_read\(\s*=\s*\)seq_read/\.proc_read_iter\1seq_read_iter/g'
> 
> This fixes a problem with the Android bionic test suite using /proc/cpuinfo
> and /proc/version for its splice based tests.
> 
> Fixes: 36e2c7421f02 ("fs: don't allow splice read/write without explicit ops")
> Reported-by: Greg KH <gregkh@...uxfoundation.org>
> Signed-off-by: Christoph Hellwig <hch@....de>

I tested some of these files, so might as well add my "mark":

Tested-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>