linux-kernel - Re: [PATCH v1 1/4] tools/power/cpupower: Read energy_perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6da5f48-5f50-a201-1f6c-5084466f81ee@linuxfoundation.org>
Date:   Fri, 30 Oct 2020 11:13:47 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Borislav Petkov <bp@...en8.de>, X86 ML <x86@...nel.org>
Cc:     Thomas Renninger <trenn@...e.com>, Shuah Khan <shuah@...nel.org>,
        Len Brown <lenb@...nel.org>, linux-pm@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v1 1/4] tools/power/cpupower: Read energy_perf_bias from
 sysfs

On 10/29/20 1:02 PM, Borislav Petkov wrote:
> From: Borislav Petkov <bp@...e.de>
> 
> ... instead of poking at the MSR. For that, move the accessor functions
> to misc.c and add a sysfs-writing function too.
> 
> There should be no functional changes resulting from this.
> 
> Signed-off-by: Borislav Petkov <bp@...e.de>
> Cc: Thomas Renninger <trenn@...e.com>
> Cc: Shuah Khan <shuah@...nel.org>
> ---
>   tools/power/cpupower/lib/cpupower.c          | 23 +++++++++-
>   tools/power/cpupower/lib/cpupower_intern.h   |  5 ++
>   tools/power/cpupower/utils/cpupower-info.c   |  2 +-
>   tools/power/cpupower/utils/cpupower-set.c    |  2 +-
>   tools/power/cpupower/utils/helpers/helpers.h |  8 ++--
>   tools/power/cpupower/utils/helpers/misc.c    | 48 ++++++++++++++++++++
>   tools/power/cpupower/utils/helpers/msr.c     | 28 ------------
>   7 files changed, 81 insertions(+), 35 deletions(-)
> 

Thanks. Looks good to me.

Reviewed-by: Shuah Khan <skhan@...uxfoundation.org>

thanks,
-- Shuah